Skip to content

feat(cli): reland annotate command, keep show --annotate#40592

Merged
pavelfeldman merged 1 commit intomicrosoft:mainfrom
Skn0tt:reland-annotate-command
May 4, 2026
Merged

feat(cli): reland annotate command, keep show --annotate#40592
pavelfeldman merged 1 commit intomicrosoft:mainfrom
Skn0tt:reland-annotate-command

Conversation

@Skn0tt
Copy link
Copy Markdown
Member

@Skn0tt Skn0tt commented May 4, 2026

Relands #40520 (reverted in 24db89b), keeping show --annotate as the CLI surface instead of introducing a top-level annotate command.

  • show --annotate now routes through the session daemon's browser_annotate MCP tool — dashboardShow.toolName is a function returning 'browser_annotate' when --annotate is set, instead of the spawn-dashboard-then-spawn-annotate flow.
  • Adds an AbortController per session-daemon socket so tool calls are cancelled when the CLI client disconnects mid-call.

Relands the architectural improvements from microsoft#40520 (reverted in
24db89b) but keeps `show --annotate` as the CLI surface instead of
introducing a top-level `annotate` command.

`show --annotate` now routes through the session daemon's
`browser_annotate` MCP tool (via `dashboardShow.toolName` becoming a
function that returns `'browser_annotate'` when `--annotate` is set),
instead of the previous spawn-dashboard-then-spawn-annotate flow.

Also adds an AbortController per session-daemon socket so tool calls
are cancelled when the CLI client disconnects mid-call.
@Skn0tt Skn0tt requested a review from dgozman May 4, 2026 10:16
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2026

Test results for "MCP"

1 failed
❌ [chromium] › mcp/dashboard.spec.ts:231 › should annotate via direct browser_annotate MCP call @mcp-windows-latest-chromium

6875 passed, 1015 skipped


Merge workflow run.

@pavelfeldman pavelfeldman merged commit e22aec7 into microsoft:main May 4, 2026
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants